Always pass focus props to setFocus #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Jun 5, 2017
blocks/library/code/index.js
Outdated
| @@ -26,7 +26,7 @@ registerBlockType( 'core/code', { | |||
| return ( | |||
| <TextareaAutosize | |||
| value={ attributes.content } | |||
| onFocus={ setFocus } | |||
| onFocus={ () => setFocus( {} ) } | |||
There was a problem hiding this comment.
Avoid passing a SyntheticEvent.
There was a problem hiding this comment.
Avoid passing a
SyntheticEvent.
Should this be added as an inline comment?
There was a problem hiding this comment.
After 3f65f3c, it doesn't even seem necessary anymore.
Related: #878 |
aduth
approved these changes
Jun 6, 2017
ellatrix
force-pushed
the
fix/hide-toolbar-type
branch
from
53b415e to
6bf7942
Compare
ellatrix
force-pushed
the
fix/hide-toolbar-type
branch
from
6bf7942 to
90e7f70
Compare
|
Do you need a fresh review here? Unclear if anything's changed since my last approval. |
|
Sorry, I left a comment (#1027 (comment)) and made a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the toolbar does not hide when typing in a quote block or table. Somehow I don't like that this is the responsibility of the block implementor but yeah. :)